highlightjs / highlight.js

JavaScript syntax highlighter with language auto-detection and zero dependencies.
https://highlightjs.org/
BSD 3-Clause "New" or "Revised" License
23.79k stars 3.61k forks source link

Proposal: Language "Champions" #2825

Closed joshgoebel closed 2 years ago

joshgoebel commented 4 years ago

Is your request related to a specific problem you're having?

It would be nice to have a way to spotlight people who go out of their way to maintain/make significant contributions to our first party grammars. Also have a "go to" person to route language specific issues to that hopefully is a bit of an expert in that language (meaning they bring a ton of language context to the table that the core team doesn't have, etc).

We could have a list in AUTHORS.txt or make a new document... open to suggestions.

The solution you'd prefer / feature you'd like to see added...

Come up with a "title" of some sort, have an official list... I'm open to other ideas. Any way to add a little "prestige" might be nice.

Any alternative solutions you considered...

Nope.

Additional context...

https://github.com/highlightjs/highlight.js/issues/1678

joshgoebel commented 4 years ago

@egor-rogov @allejo

Pinging a few people who've made large grammar contributions lately. @halirutan @schtandard @klmr

klmr commented 4 years ago

I like the idea of having a “go to” person, and I’d be happy to fulfil this role for the R language definition (plus potentially others in the future).

halirutan commented 4 years ago

It was always my belief that when I put my name on it, I'm responsible for it. It doesn't mean that I have to do all future work/fixes, but I always tried to be approachable when issues pop up so that I can help or give advice. For the Wolfram Language, I have quite a collection of highlighters in my bag:

That being said, I don't need a champions-club to feel responsible but it surely is a very nice idea. The big problem with such things is always where to put it so that anyone even sees it. Because right now, we already have a champions-club and it's called AUTHORS.txt 😂

image

(btw, above image is the logo of Dr. Disrespect's champions club. Do not just use it :)

schtandard commented 4 years ago

It was always my belief that when I put my name on it, I'm responsible for it. It doesn't mean that I have to do all future work/fixes, but I always tried to be approachable when issues pop up so that I can help or give advice.

This is how I feel, too. I would add that this also goes the other way: I would like to actually be approached when changes to the LaTeX grammar are discussed. I don't think GitHub has a feature to facilitate this (I might be wrong). Designating contributors as go-to persons for specific languages may be useful for this, too.

The name "Language Champion" sounds a bit weird to me, though. It feels like an achievement in a video game. (This may be just me, of course.) The best alternative I could come up with right now is "Sponsor" (in the sense of a godparent).

halirutan commented 4 years ago

@schtandard I agree on all points.

I don't think GitHub has a feature to facilitate this (I might be wrong).

One simple solution we used in another project is to just ping the right person if an issue pops up. When my name is mentioned somewhere, I get a notification in my inbox. Also, I assume it's easy for the maintainers to just ping the Godparent in an issue/PR to ensure they don't overlook any subtleties that might break things.

The name "Language Champion" sounds a bit weird to me

I wouldn't mind if it's something funny/original that sticks. I like Godparent much more than Sponsor (which sounds so much like money). I guess we have a ton of funny things that we could use for ideas, like the elders of the internet :)

joshgoebel commented 4 years ago

Language Elders sounds very middle earth or something. :)

joshgoebel commented 4 years ago

Related but very different I think we could also use a "themes champion"... someone who was more visual oriented (designer?) and had an interest in themes and language highlighting in perhaps a more abstract sense: https://github.com/highlightjs/highlight.js/issues/2817

joshgoebel commented 2 years ago

Closing discussion for now. Anyone who wants to step up and actively maintain a grammar is welcome to be champion of record.