highlightjs / highlight.js

JavaScript syntax highlighter with language auto-detection and zero dependencies.
https://highlightjs.org/
BSD 3-Clause "New" or "Revised" License
23.31k stars 3.52k forks source link

Respect --no-minify when building CDN assets #3913

Closed allejo closed 8 months ago

allejo commented 8 months ago

When building the grammars for CDN, they will always be minified in the build directory, regardless of the --no-minify flag given to tools/build.js.

Changes

I know CDN assets will never be published in a non-minified format. However, if these grammars are built in a non-minified way, they can be used to address https://github.com/highlightjs/highlightjs.org/issues/5. Since the /download bundle uses a concatenated version of minified grammars, the non-minified distribution should use the same grammars.

github-actions[bot] commented 8 months ago

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

3 files changed

Total change +6 B

View Changes | file | base | pr | diff | | --- | --- | --- | --- | | es/core.min.js | 8.13 KB | 8.14 KB | +2 B | | es/highlight.min.js | 8.13 KB | 8.14 KB | +2 B | | highlight.min.js | 8.17 KB | 8.17 KB | +2 B |
github-actions[bot] commented 8 months ago

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

3 files changed

Total change +6 B

View Changes | file | base | pr | diff | | --- | --- | --- | --- | | es/core.min.js | 8.13 KB | 8.14 KB | +2 B | | es/highlight.min.js | 8.13 KB | 8.14 KB | +2 B | | highlight.min.js | 8.17 KB | 8.17 KB | +2 B |