highlightjs / highlight.js

JavaScript syntax highlighter with language auto-detection and zero dependencies.

https://highlightjs.org/

BSD 3-Clause "New" or "Revised" License

23.31k stars 3.52k forks source link

(chore) update Node.js test versions #3954

Closed bradleymackey closed 6 months ago

bradleymackey commented 6 months ago

Changes

Drop Node 16 support from test matrix, this is no longer supported or receiving security updates.
Start testing "Current" versions as well, starting with v21. This will allow us to catch issues caused by new releases ASAP.

Checklist

~~[ ] Added markup tests, or they don't apply here because..~~.
[x] Updated the changelog at CHANGES.md

github-actions[bot] commented 6 months ago

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

3 files changed

Total change +9 B

View Changes

| file | base | pr | diff | | --- | --- | --- | --- | | es/core.min.js | 8.17 KB | 8.17 KB | +3 B | | es/highlight.min.js | 8.17 KB | 8.17 KB | +3 B | | highlight.min.js | 8.2 KB | 8.21 KB | +3 B |

joshgoebel commented 6 months ago

While we're at it shouldn't we add 22 and 24 to CI?

bradleymackey commented 6 months ago

I don't think there's releases available for these yet. The current latest is v21, but that's not LTS. We should possibly test against this too though so we can catch any issues caused by new releases ASAP.

github-actions[bot] commented 6 months ago

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

3 files changed

Total change -6 B

View Changes

| file | base | pr | diff | | --- | --- | --- | --- | | es/core.min.js | 8.17 KB | 8.17 KB | -2 B | | es/highlight.min.js | 8.17 KB | 8.17 KB | -2 B | | highlight.min.js | 8.21 KB | 8.21 KB | -2 B |

github-actions[bot] commented 6 months ago

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

3 files changed

Total change -3 B

View Changes

| file | base | pr | diff | | --- | --- | --- | --- | | es/core.min.js | 8.17 KB | 8.17 KB | -1 B | | es/highlight.min.js | 8.17 KB | 8.17 KB | -1 B | | highlight.min.js | 8.21 KB | 8.21 KB | -1 B |

joshgoebel commented 6 months ago

I don't think there's releases available for these yet. The current latest is v21,

Turns out I was looking at the roadmap... LOL... yes, we should test v21 also.

github-actions[bot] commented 6 months ago

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

3 files changed

Total change -10 B

View Changes

| file | base | pr | diff | | --- | --- | --- | --- | | es/core.min.js | 8.18 KB | 8.17 KB | -3 B | | es/highlight.min.js | 8.18 KB | 8.17 KB | -3 B | | highlight.min.js | 8.21 KB | 8.2 KB | -4 B |