search

highlightjs / highlight.js

JavaScript syntax highlighter with language auto-detection and zero dependencies.
https://highlightjs.org/
BSD 3-Clause "New" or "Revised" License
23.31k stars 3.52k forks source link

Some styles/*.css files do not have semi-colons in portions. #3966

Closed m34github closed 5 months ago

m34github commented 5 months ago

Describe the issue/behavior that seems buggy

Some theme's css files do not have semi-colons in portions. It does not affect to behaviors, is just for the coding-style.

e.g. src/styles/googlecode.css

Sample Code or Instructions to Reproduce

The following css files do not have semi-colon(s).

Expected behavior

Not recommended

.foo {
  color: #FFF
}

Recommended

.foo {
  color: #FFF;
}

Additional context

I could not find the coding-style-guide, linter-rule, or something like that. However, In my opinion, it is better to write codes in the same way.

joshgoebel commented 5 months ago

If we were to start linting the CSS we'd need to:

We really don't want to add additional obstacles to contributing, so I think we're just not that interested in linting our CSS. Also, the final build assets should already be CSS beautified/standardized.

m34github commented 5 months ago

@joshgoebel Thanks for your reply. I also think that linter is not needed now. My suggestion had focused on only that adding semi-colon to css files. If it's not sensitive about code-format in here's community, I'm ok that this issue can be closed.

joshgoebel commented 5 months ago

My suggestion had focused on only that adding semi-colon to css files.

Without a linter and enforcement you can't guarantee those changes will even stay put long term - or that new themes added would be consistent... given that it's not worth the time to even review such PRs.

not sensitive about code-format in here's community

We do have linting for the JS code, and our CSS files are clean and readable (which is what really matters) even if not perfectly consistent. So we absolutely have some standards, perhaps just not as many as some would like...