search

highlightjs / highlight.js

JavaScript syntax highlighter with language auto-detection and zero dependencies.
https://highlightjs.org/
BSD 3-Clause "New" or "Revised" License
23.31k stars 3.52k forks source link

download page bug #3971

Closed BenRacicot closed 3 months ago

BenRacicot commented 5 months ago

Hi, when I select "all languages" on the downloads page and download, I get a 139 byte file that cannot be unzipped. Just reporting what I believe its a bug, hope this is helpful.

tomwt-awa commented 5 months ago

Because the file will be too big. You'll get it if you open the zip file with a text editor. It'll be ok if you download "common" only.

joshgoebel commented 5 months ago

@allejo Couldn't we first add up the sizes of all the grammars (pre-zip) and have some magic threshold we set that tells people they picked too many - and to try again? We should not encourage builds with ALL the grammars anyways as that's just silly and forcing the browser to do extra parsing over and over for obscure grammars someone will never need.

BenRacicot commented 5 months ago

Yeah @joshgoebel was going to reply something similar, I actually didn't need the download because of Github files/releases.

Was looking for the CSS files and just reporting to help out.

joshgoebel commented 5 months ago

Do we have an "all" build in releases?

janbrasna commented 3 months ago

FYi this is also tracked in https://github.com/highlightjs/highlightjs.org/issues/15

joshgoebel commented 3 months ago

Closing as dup of #15 from the website repo.