search

highlightjs / highlightjs-extempore

Highlight.js Extempore language repository
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

lexemes doesn't do anything #6

Closed joshgoebel closed 3 years ago

joshgoebel commented 3 years ago

lexemes doesn't do anything unless paired with keywords which you aren't using (that I can see). So you could remove it entirely.

benswift commented 3 years ago

Thanks @joshgoebel . @cyblue9 I guess this is because we might move to using them in the future? Tbh it's working pretty well at the moment, so I don't think changing it is a high priority with your/my limited time :)

benswift commented 3 years ago

So I guess we could remove the lexemes stuff just to avoid confusion.

cyblue9 commented 3 years ago

@joshgoebel @benswift

Sorry for late response. Thank you for advice. At the time of writing this source, I didn't understand how to use "lexemes". Perhaps it's okay to remove the lexeme. I will commit this weekend!

joshgoebel commented 3 years ago

It only affects keywords, and now it's been replaced by keywords.$pattern, to make this clearer.

cyblue9 commented 3 years ago

@joshgoebel Hmm, I read highlightjs docs. I understood how to use keywords.$pattern(old lexeme). It's doesn't do anything in this source. I removed lexeme at bdb27b37c86c968371288062052e2a5ad4190a47. Please review!

cyblue9 commented 3 years ago

@benswift Is it OK of syntax highlight in extempore docs ? (I checked it myself)