search

highlightjs / highlightjs.org

The source code for the official highlightjs.org website, powered by Next.js
http://highlightjs.org
22 stars 10 forks source link

custom package only minified version is custom #18

Open pandrr opened 1 year ago

pandrr commented 1 year ago

Describe the issue/behavior that seems buggy

first: thanks for the great work, appreciate it !

when creating a custom package on your website, a custom .min.js file is created inside the zip. the non minified version seems to not contain any languages and has an old file date.

Sample Code or Instructions to Reproduce

  1. goto https://highlightjs.org/download/
  2. click download

Expected behavior

highlight.js contains the selected languages.

Additional context

see filedates in the zip file:

Screenshot 2022-11-16 at 11 26 40

joshgoebel commented 1 year ago

highlight.js is the stand-alone core library. The only real build asset of custom build is highlight.min.js...

What would be the reasons to include a non-minified custom build?

pandrr commented 1 year ago

because in my case i use it to build a bigger file with multiple libs in there and minify them again.

joshgoebel commented 1 year ago

This seems an edge case to me (for most users) - more custom builds can easily use our official build toolchain... @allejo up to you if you want to add this to the new website or welcome a PR for it.

One problem is we'd have to rejigger the naming, which could break peoples assumptions about the download content.

joshgoebel commented 8 months ago

@allejo didn't we fix this now?

janbrasna commented 7 months ago

Fixed in https://github.com/highlightjs/highlightjs.org/pull/10 where api/download.ts#L159-L164