search

highlightjs / vue-plugin

Highlight.js Vue Plugin
BSD 3-Clause "New" or "Revised" License
200 stars 28 forks source link

Change highlight.js/vue to peerDependencies to enforce versions #17

Closed Trinovantes closed 2 years ago

Trinovantes commented 2 years ago

As discussed in #12, changing highlight.js and vue to peerDependencies will force the user to have compatible versions to prevent multiple singleton resolutions

https://nodejs.org/en/blog/npm/peer-dependencies/

joshgoebel commented 2 years ago

I assume after we did this we'd need to publish a new release?

Trinovantes commented 2 years ago

Yes

Although I'm not sure if this counts as a breaking change that require a major version bump

joshgoebel commented 2 years ago

Oh no, I don't imagine it's a major bump.

joshgoebel commented 2 years ago

2.1.0 released