search

highlightjs / vue-plugin

Highlight.js Vue Plugin
BSD 3-Clause "New" or "Revised" License
207 stars 27 forks source link

Maintainer needed. #19

Open joshgoebel opened 3 years ago

joshgoebel commented 3 years ago

As this is now no longer part of Highlight.js core and issues here more often than not have more to do with Vue.js (or build systems, etc) than they do with Highlight.js, we're looking for a new maintainer for this project.

Twoody commented 3 years ago

@joshgoebel I am wanting to plug this in and am apt to make another package at this point.... Let me know if you are interested to talk further.

joshgoebel commented 3 years ago

I am wanting to "plug this in" and am apt to "make another package"

I'm not sure what you're saying exactly... you want to replace the project with your own?

Twoody commented 3 years ago

@joshgoebel Biggest issue with this repo is lack of slot integration. Otherwise, it works great! I'm right in the middle of plugging in prism6 on my project as I want more options than single line syntaxing.

I'm saying I would offer maintaining and updating the repo instead of creating my own.

joshgoebel commented 3 years ago

Biggest issue with this repo is lack of slot integration.

Well at the time I purposely avoided this because slots using HTML (vs just text) were problematic (IIRC)... but since we no longer support unescaped HTML in paste content in general then I think perhaps that roadblock is now no longer an issue.

Are you just imagining a single slot to set the initial code content if code isn't passed?

I'm saying I would offer maintaining and updating the repo instead of creating my own.

Well, jump in and help out and we'll see how it goes.

joshgoebel commented 2 years ago

Biggest issue with this repo is lack of slot integration.

Or perhaps I misunderstood what you meant... what was your thinking with slots?

joshgoebel commented 2 years ago

what was your thinking with slots?

Twoody commented 2 years ago

Sorry @joshgoebel , I can't recall off the top of my head, but I believe the idea is to remove prop associated strings, and making everything slot and template based.

I can't go into more detail than that without spending adequate time.

joshgoebel commented 2 years ago

How does one programmatically change the slot content at runtime then? Do you just fall back to DOM methods (but then you'd have to manage Vue callbacks manually, yes?). I'm not so certain that one is 100% superior to the other - though I'd wager people have their favorites, like in most tech...

I think at the time I liked how with props you couldn't accidentally inject unintended HTML into the page - but if we're going to handle that more strongly in v12 then perhaps that's not the plugins responsibility. Though hopefully Vue developers would be slightly less likely to do that than someone who just knows HTML?