Update to Vue 3 and add Typescript definition

highlightjs / vue-plugin

Highlight.js Vue Plugin

BSD 3-Clause "New" or "Revised" License

200 stars 28 forks source link

Update to Vue 3 and add Typescript definition #3

Closed Trinovantes closed 3 years ago

joshgoebel commented 3 years ago

Wow. Thanks.

I assume Vue 2 isn't going anywhere though, so now we have to figure out how to support both...

Do we just need a new branch and Vue 2 becomes "deprecated"?
Can this be made compatible with both 2 and 3?
Should both be provided side by side (as sep source files) in this repo and maintained?
Two repos?

How are most other Vue plugins handling this?

Trinovantes commented 3 years ago

Most plugins just use a major version release bump so npm/yarn updates won't introduce breaking changes e.g. Vuex 3 supports Vue 2, Vuex 4 supports Vue 3 (awkward numbering). They also have a legacy branch for back porting security fixes for Vue 2 users

Vue 2 users should also be able to use this plugin if they use @vue/composition-api that basically pollyfills the Vue 3 API into Vue 2

joshgoebel commented 3 years ago

Can this please be rebased to pull in the small change from https://github.com/highlightjs/vue-plugin/pull/4?

Sorry for the delay. After that I'll find the time to get this merged and make a new release.

Trinovantes commented 3 years ago

Rebased with current HEAD