highmed / highmed-dsf

HiGHmed Data Sharing Framework funded by the German Federal Ministry of Education and Research (BMBF, grant ids: 01ZZ1802E and 01ZZ1802A)
Apache License 2.0
32 stars 20 forks source link

CVE-2022-22965 #330

Closed bauerjs1 closed 2 years ago

bauerjs1 commented 2 years ago

Hello everybody,

first of all, thank you for the current update and its related security fixes! As you might know, a new day-0 security hole was found in the Spring core packages (CVE-2022-22965).

While building the new BPE image 0.5.5 (I'm building a custom image on top of it), Trivy scanner alerted me on this one:

+----------------------------------+------------------+----------+-------------------+----------------+---------------------------------------+
|             LIBRARY              | VULNERABILITY ID | SEVERITY | INSTALLED VERSION | FIXED VERSION  |                 TITLE                 |
+----------------------------------+------------------+----------+-------------------+----------------+---------------------------------------+
| org.springframework:spring-beans | CVE-2022-22965   | CRITICAL | 5.3.16            | 5.3.18, 5.2.20 | spring-framework: RCE via             |
|                                  |                  |          |                   |                | Data Binding on JDK 9+                |
|                                  |                  |          |                   |                | -->avd.aquasec.com/nvd/cve-2022-22965 |
+----------------------------------+------------------+----------+-------------------+----------------+---------------------------------------+

Would it be possible to release a hotfix for this one by updating the Spring dependencies?

Thanks in advance and cheers, Johannes

P.S.: As noted in the release page, the recent update needs more maintenance than just bumping the image tags. Since I am not using the exact same deployment strategy than in the examples (no docker secrets, unified .env file for DSF-FHIR, Kubernetes Helm deployment for BPE), it is quite hard to find out breaking changes in the configuration of the containers themselves. Is there an overview somewhere? Moreover, if you're interested in the deployments I use (and publish in the Miracum context), let me know.

bauerjs1 commented 2 years ago

Relates to #326

hhund commented 2 years ago

We have looked extensively at CVE-2022-22965 and especially the reports coming from the developers at Spring:

Am I Impacted? These are the requirements for the specific scenario from the report:

Based on the "Am I Impacted" statements and the actual code that was fixed, we have concluded that we are not impacted by CVE-2022-22965. We use Jetty as our Servlet container, the fhir and bpe applications are not packaged as WAR files and we have no dependency to spring-webmvc and spring-webflux.

I have added a few notes for none standard deployments to the upgrade guide.

The spring-beans dependency will be upgrade with the next scheduled release which is currently 0.6.0.

bauerjs1 commented 2 years ago

Alright, thanks a lot for the explanation and the additional notes in the update guide! 👍🏻