highmed / highmed-dsf

HiGHmed Data Sharing Framework funded by the German Federal Ministry of Education and Research (BMBF, grant ids: 01ZZ1802E and 01ZZ1802A)
Apache License 2.0
32 stars 20 forks source link

Issues/331 add bookmarking function to html output #332

Closed hhund closed 2 years ago

hhund commented 2 years ago

closes #331

hhund commented 2 years ago

One thing I noticed: when deleting a bookmark directly in the bookmark list view, only the icon changes from "delete bookmark" to "add bookmark" and the bookmark stays in the list. If this is intended behavior, it works fine. I initially expected the bookmark to be removed from the list, when clicking the remove icon.

This is the intended behavior and the bookmark is actually removed from local storage. The rational is, that the user can undo a remove without having to type the entire query again. Similar to the way you can "toggle" the bookmark of the current page. I will try to give more feedback to the user: Grey or strike-through text, not sure yet.

Update: Decided on a grey link text, see 4fec9d3.