Closed SolarAquarion closed 6 years ago
I have created a "meson" branch, and merged this pull request into that. Please use that for future pull requests.
cpp_std=c++98
Then?
On Nov 26, 2017 6:10 PM, "Russell Standish" notifications@github.com wrote:
@highperformancecoder commented on this pull request.
In meson.build https://github.com/highperformancecoder/classdesc/pull/1#discussion_r153085470 :
@@ -4,7 +4,7 @@ project('classdesc', 'c', meson_version: '>=0.39.1', license: [ 'GPL3+', 'MIT' ], default_options: [
- 'c_std=gnu11',
- 'c_std=gnu99',
This is a C++ project, and the version to target is c++98.
There is one test directory that tests classdesc compatibility with more recent C++ standards, currently set to C++11, but due to be updated to C++17 shortly.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/highperformancecoder/classdesc/pull/1#pullrequestreview-79041410, or mute the thread https://github.com/notifications/unsubscribe-auth/AFD6iIJIn8E3Yhf1e0j3dx-o05G_Zk5Aks5s6e_PgaJpZM4Qq1yo .
It can probably be a sed job to update that line
On Nov 26, 2017 6:13 PM, "Russell Standish" notifications@github.com wrote:
@highperformancecoder commented on this pull request.
In meson.build https://github.com/highperformancecoder/classdesc/pull/1#discussion_r153085540 :
@@ -0,0 +1,15 @@ + +project('classdesc', 'c',
- version: '3.34',
Needs to be auto generated from the makeRelease.sh script.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/highperformancecoder/classdesc/pull/1#pullrequestreview-79041477, or mute the thread https://github.com/notifications/unsubscribe-auth/AFD6iI8TLRnJ_gfA8c490D8wmB2d40buks5s6fB8gaJpZM4Qq1yo .
Needs to pass Travis CI builds (see .travis.yml), including the full regression suite before being merged into master.
Closing PR now, as the code is merged.
cpp_std=c++11
On Nov 26, 2017 6:14 PM, "Solomon Choina" shlomochoina@gmail.com wrote:
It can probably be a sed job to update that line
On Nov 26, 2017 6:13 PM, "Russell Standish" notifications@github.com wrote:
@highperformancecoder commented on this pull request.
In meson.build https://github.com/highperformancecoder/classdesc/pull/1#discussion_r153085540 :
@@ -0,0 +1,15 @@ + +project('classdesc', 'c',
- version: '3.34',
Needs to be auto generated from the makeRelease.sh script.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/highperformancecoder/classdesc/pull/1#pullrequestreview-79041477, or mute the thread https://github.com/notifications/unsubscribe-auth/AFD6iI8TLRnJ_gfA8c490D8wmB2d40buks5s6fB8gaJpZM4Qq1yo .
Yes - sed is a suitable tool.
I have no idea how to do it really
On Nov 26, 2017 6:20 PM, "Russell Standish" notifications@github.com wrote:
Yes - sed is a suitable tool.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/highperformancecoder/classdesc/pull/1#issuecomment-347047426, or mute the thread https://github.com/notifications/unsubscribe-auth/AFD6iCq2nut-h2mj0PQDWZHrD4O0uaF7ks5s6fJHgaJpZM4Qq1yo .
On Sun, Nov 26, 2017 at 11:24:10PM +0000, SolarAquarion wrote:
I have no idea how to do it really
No worries, it's quite simple - stick it on the todo list (create a github issue perhaps), and I'll get to it later.
I'm more interested in seeing how meson can autoupdate its dependency list.
Cheers --
We do need .sln's, and vcxproj's because meson creates those
This change is