Closed Rdmkr closed 2 months ago
highperformancecoder
commented
3 months ago I won't merge this right now - firstly it is mixed up with your work on the URL downloader, so a merge up from master branch is required. Secondly, since there's no actions attached to the new input fields, its not a good look to go to release with this. I'd be happy to merge this into develop branch, though.
Rdmkr
commented
3 months ago I've added the layout changes to this branch.
"firstly it is mixed up with your work on the URL downloader, so a merge up from master branch is required" I started this branch from that other branch, so there would not be conflicts. Just merged master into this branch without any problems. " since there's no actions attached to the new input fields" Clarify this please?
"I'd be happy to merge this into develop branch, though." Acceptable to me, although I think our first users will like to see the new layout, which I could put in a different branch if required.
Please give confirmation on the preferred approach
Rdmkr
commented
2 months ago I'll be happy to correct those last two errors, but they were already there before I started work on this
highperformancecoder
commented
2 months ago On Tue, Jun 11, 2024 at 01:32:44AM -0700, Rdmkr wrote:
I'll be happy to correct those last two errors, but they were already there before I started work on this
Fair enough. I fixed them during the merge anyway :). Looking good, by the way!
--
Parameter name / descriptions input in CSV import dialog, as requested in this ticket: https://sourceforge.net/p/minsky/ravel/463/
This version only has the extra input fields and no changes to the layout of the dialog yet. See ticket on further suggestions on improvements to the CSV import dialog's layout.
This change is