highskillmasters / highskillmasters-api

High Skill Masters API
https://api.highskillmasters.com
MIT License
2 stars 2 forks source link

Implement tests #1

Open rahmanfadhil opened 4 years ago

rahmanfadhil commented 4 years ago

This project needs some tests. Please put the dependencies / softwares to include in the test environment.

highskillmasters-admin commented 4 years ago

Thank you @rahmanfadhil for the heads up.

Would you like to provide the implementation of your best practices to handle those?

Would really appreciate it.

rahmanfadhil commented 4 years ago

Yeah,

Which test framework you want to use? There are plenty of options:

highskillmasters-admin commented 4 years ago

@rahmanfadhil Jest would be preferable as it is more familiar for the current year of new developers. @mhaidarh already familiar with both Jest and Mocha though.

In the other hand, we'd like to ask new developers to contribute to the project too.

Also, Kent C. Dodds, the testing dude encourage using Jest (taken from https://testingjavascript.com).

Screenshot 2020-07-25 at 07 58 53
rahmanfadhil commented 4 years ago

Cool!

So, nothing else besides MongoDB and Node?

highskillmasters-admin commented 4 years ago

@rahmanfadhil For now, yes, just that minimal. If you have any additional idea or updates, you can also propose it here. Your account also already eligible to create new repo.

As in current situation, @mhaidarh is focusing on the content building first.

Keep in mind that the repositories would be used for learning purpose inside High Skill Masters community too, so it is expected to have some new developers who'd like to contribute later on.

highskillmasters-admin commented 4 years ago

Tests are implemented, but still have issues. Have to continue later.