highsource / jaxb-tools

The most advanced JAXB2 Maven Plugin for XML Schema compilation.
Other
422 stars 98 forks source link

Rename jaxb-tools/jaxb-bom to jaxb-tools-bom to not confuse w/ the upstream jaxb-bom #480

Open mattrpav opened 7 months ago

mattrpav commented 7 months ago
bschuhmann commented 6 months ago

Apologies to hijack this issue, but while you're looking into jaxb-bom can you maybe fix this:

...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] 'dependencies.dependency.version' for jakarta.xml.bind:jakarta.xml.bind-api:jar must be a valid version but is '${jaxb-api.version}'. @ org.jvnet.jaxb:jaxb-bom:4.0.3, ~/.m2/repository/org/jvnet/jaxb/jaxb-bom/4.0.3/jaxb-bom-4.0.3.pom, line 24, column 18
...
[ERROR]   The project org.acme:myproject:0.0.1 (~/myproject/pom.xml) has 1 error
[ERROR]     'dependencies.dependency.version' for jakarta.xml.bind:jakarta.xml.bind-api:jar must be a valid version but is '${jaxb-api.version}'. @ org.jvnet.jaxb:jaxb-bom:4.0.3, ~/.m2/repository/org/jvnet/jaxb/jaxb-bom/4.0.3/jaxb-bom-4.0.3.pom, line 24, column 18
...

Not sure if just I'm doing something wrong. But it seems the property jaxb-api.version is used in jaxb-bom/pom.xml but nowhere defined in the project.

🤔 it shouldn't even be necessary to configure jakarta.xml.bind:jakarta.xml.bind-api in jaxb-tools-bom as it's already configured in org.glassfish.jaxb:jaxb-bom, which gets imported in root POM?

laurentschoelens commented 6 months ago

@bschuhmann could you please provide MRE ?

laurentschoelens commented 6 months ago

@bschuhmann : I've seen the error, no MRE needed, we'll look into this.

If needed of jaxb-bom, you can safely use the jaxb-ri one

<groupId>org.glassfish.jaxb</groupId>
<artifactId>jaxb-bom</artifactId>

Or the ext one

<groupId>com.sun.xml.bind</groupId>
<artifactId>jaxb-bom-ext</artifactId>