search

highsource / jaxb-tools

The most advanced JAXB2 Maven Plugin for XML Schema compilation.
Other
425 stars 98 forks source link

Needs update to latest commons-lang3 & commons-text #540

Closed davija closed 3 months ago

davija commented 4 months ago

Version 4.0.6 of jaxb-maven-plugin & jaxb-plugin-annotate rely on a method that has been deprecated and running with any version later 3.12.0 breaks.

This is in: org.apache.commons.text.translate.NumericEntityEscaper.between (NumericEntityEscaper.java:59) image

Please update to use the latest commons-lang3 & commons-text libraries.

davija commented 4 months ago

Digging through the code it appears this is related to usage of StringEscapeUtils from org.apache.commons.text.StringEscapeUtils

mattrpav commented 4 months ago

Our usage of commons-* is pretty minimal. We may look to remove it altogether and either use more modern JDK built-in functions or self-host a few of the utilities that are used.

davija commented 4 months ago

That would be nice, but in the mean time we need something that works with newer versions as we have dependencies which require newer versions. When we use the newer versions, this plugin pukes.

laurentschoelens commented 4 months ago

@davija thanks for the report @mattrpav : outside of plugin's usage, it would be nice to drop some dependencies

laurentschoelens commented 4 months ago

The #542 PR fixes the issue here by removing the unwanted / conflicted dependencies.

laurentschoelens commented 4 months ago

@davija feel free to look at the PR

davija commented 4 months ago

@laurentschoelens I looked at it this morning and it should resolve my issue so I closed my PR in favor of this one.

laurentschoelens commented 3 months ago

@davija 4.0.7 just been released and should be available in maven central soon

laurentschoelens commented 3 months ago

You can also go for 4.0.8 which includes another fix (for another unrelated issue)

Regards