search

highsource / jaxb2-basics

Useful plugins and tools for JAXB2.
BSD 2-Clause "Simplified" License
109 stars 54 forks source link

Make equals symmetric #39

Closed codecholeric closed 9 years ago

codecholeric commented 9 years ago

Hi,

I think the generated equals code is somewhat flawed by creating equals methods that are not symmetric. We actually had a problem with this in our project, because adding a supertype to a HashSet would prevent any subtype with no preinitialized properties to be added to the Set, while the other way around adding is possible (the instanceof check instead of type equality). Thus this can lead to really erratic behavior (in our case we injected multibound generated classes via Guice and depending on the order Guice decided to add these types to the Set to inject, we ended up with a different amount of elements).

Greetings, Peter

highsource commented 9 years ago

Just added this., otherwise it's good.

I'll bump the version because this is potentially backwards incompatible.

Thank you for your contribution.

codecholeric commented 9 years ago

Great, thanks for the merge :-) Looking forward to 0.9.6 then,so we can throw away the patched version in our local Nexus :-)

Am 21. November 2015 00:02:04 MEZ, schrieb Alexey Valikov notifications@github.com:

Just added this., otherwise it's good.

I'll bump the version because this is potentially backwards incompatible.

Thank you for your contribution.

Reply to this email directly or view it on GitHub: https://github.com/highsource/jaxb2-basics/pull/39#issuecomment-158551796

Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.