search

highsource / jaxb2-basics

Useful plugins and tools for JAXB2.
BSD 2-Clause "Simplified" License
108 stars 54 forks source link

Make simple equals symmetrical as well #40

Closed codecholeric closed 8 years ago

codecholeric commented 8 years ago

Hi,

we were on an old version of jaxb2-basics for a long while, so I just saw, that actually SimpleEquals would be completely sufficient for our needs (we have no custom equals strategy). Would you be up for merging the equals fix into SimpleEquals as well? Then we could switch to -XsimpleEquals in our project.

Thank you and greetings, Peter

ja6a commented 8 years ago

+1

On 21 Nov 2015, at 6:36 p.m., petega notifications@github.com wrote:

Hi,

we were on an old version of jaxb2-basics for a long while, so I just saw, that actually SimpleEquals would be completely sufficient for our needs (we have no custom equals strategy). Would you be up for merging the equals fix into SimpleEquals as well? Then we could switch to -XsimpleEquals in our project.

Thank you and greetings, Peter

You can view, comment on, or merge this pull request online at:

https://github.com/highsource/jaxb2-basics/pull/40

Commit Summary

Make simple equals symmetrical if one compares a supertype and a subtype with no unequal properties File Changes

M basic/src/main/java/org/jvnet/jaxb2_commons/plugin/simpleequals/SimpleEqualsPlugin.java (10) Patch Links:

https://github.com/highsource/jaxb2-basics/pull/40.patch https://github.com/highsource/jaxb2-basics/pull/40.diff — Reply to this email directly or view it on GitHub.

highsource commented 8 years ago

Great, just how I'd wrote this. Merged, so I'll do the 0.10.x release now. Hope it will work with this internet here...