highsource / jaxb2-basics

Useful plugins and tools for JAXB2.
BSD 2-Clause "Simplified" License
109 stars 54 forks source link

Element with null parent #80

Open bertramn opened 7 years ago

bertramn commented 7 years ago

Just wondering if this method of adding the property to the ClassInfo will construct a valid ElementProperty?

https://github.com/highsource/jaxb2-basics/blob/master/basic/src/main/java/org/jvnet/jaxb2_commons/plugin/simplify/SimplifyPlugin.java#L167

The source of com.sun.tools.xjc.model.CClassInfo suggests that one should call addProperty for it to be setup correctly. The setParent method on CPropertyInfo is package scoped and hence cannot be called outside.

    public void addProperty(CPropertyInfo prop) {
        if(prop.ref().isEmpty())
            // this property isn't contributing anything
            // this happens when you try to map an empty sequence to a property
            return;
        prop.setParent(this);
        properties.add(prop);
    }
highsource commented 7 years ago

Maybe you're right and parent is not initialized correctly. But still, the plugin works so far. :) So probably this parent is not used much.