highstreet-technologies / transportpce

Mirror of the OpenDaylight transportpce gerrit project
1 stars 1 forks source link

Update documentation, maven settings sample file and fix build CS and SB errors #6

Open guillaumelambert opened 3 years ago

guillaumelambert commented 3 years ago

Hello

Thank you for using TransportPCE. I am proposing this PR to fix current build errors and to reestablish by default checkstyle and SpotBugs enforcement at buildtime. If neeeded, they can be disabled on demand by simply calling maven with the options " -Dodlparent.spotbugs.skip " and "-Dodlparent.checkstyle.skip" . I've updated the documentation this way and also the maven settings xml sample file in the tests folder so that the project can be built without touching the local environment.

I fixed or ignored a few non trivial issues pointed by checkstyle and Spotbugs but I am not totally sure these fixes are completely revelant nor they work properly everywhere. I did not manage to fully test everything yet. I'll let you check this proposal and adapt it at your convenience.

Hope this helps