hightower8083 / synchrad

Synchrotron Radiation calculator via openCL
GNU General Public License v3.0
18 stars 11 forks source link

`numba` is also a dependency #26

Closed berceanu closed 1 year ago

berceanu commented 1 year ago

It seems numba should be added to the requirements file. Also, openpmd_viewer 1.X uses from openpmd_viewer import .. instead of from opmd_viewer import .., as stated in the README

hightower8083 commented 1 year ago

hi @berceanu

yes this part with numba import is assumed but is not correct. Actually numba is only used for a couple of secondary methods in converters and is not necessary for any actual synchrad's functionality. I would prefer to keep numba dependency optional -- it's a big one and has its own specific relations to numpy. I've added handling of not-installed case with a warning