search

highvolt-dev / tmo-monitor

A lightweight, cross-platform Python 3 script that can monitor the T-Mobile Home Internet Nokia, Arcadyan, and Sagecom 5G Gateways for 4G/5G bands, cellular site (tower), and internet connectivity and reboots as needed or on-demand.
MIT License
89 stars 15 forks source link

Add Linting Rules #28

Open highvolt-dev opened 2 years ago

highvolt-dev commented 2 years ago

Add linting rules for better consistency of code. Incorporate in GitHub Actions.

asheingold commented 2 years ago

Do you have a preferred rule set for linting?

highvolt-dev commented 2 years ago

@asheingold I don't, but if there are several competing opinionated rulesets and one contradicts the existing style more than the other (generates more linting errors), we may want to select the ruleset that most reflects the current codebase so as to minimize the amount of revisions that will be needed to pass the linting tests. That being said the current code was contributed by multiple people and we want consistency. I do like to see Pythonic/idiomatic code.

I don't want to get in the way of you contributing, so I am open-minded about the ruleset selection