Need to fix the assertion in the test for asset_class_advisor

highwire-ai / open-robo-advisor

Open Robo-Advisor is a flexible robo-advisor library written in Python. 🤖

https://blog.highwire.ai

BSD 3-Clause "New" or "Revised" License

42 stars 3 forks source link

Need to fix the assertion in the test for asset_class_advisor #22

Closed amkolhar closed 2 years ago

amkolhar commented 2 years ago

https://github.com/highwire-ai/open-robo-advisor/blob/b24cbed73856937bd2c11df10e1d565733e191b2/tests/openroboadvisor_tests/advisor/test_asset_class_advisor.py

In line 56, the assertion failure message is set wrong ( or just copied from the other test). The required message in the test is supposed to be Expected 2.0933 SPY shares.

The test when fails will lead to the wrong failure message.

criccomini commented 2 years ago

Ah, good catch!