Closed Lmercadom closed 4 years ago
Thanks for the PR Luisa! I made some inline suggestions but more importantly than that, would you mind adding some tests?
Also, could you update the CHANGELOG with your changes?
Looks reasonable. A minor comment: your test file contains values for chr1 and chr2 but you never use chr2 in the actual test. Does it need to be in the test file or is it just a red herring?
It is just a red herring. I just wanted to signal that chr1 ended.
Description
What was changed in this pull request and Why is it necessary?
Modified multivec.py to retain bedlines in which the end coordinate is not a multiple of the resolution (It adds an extra bin for the remainder). This avoids losing information when having large chromosome segments that are not multiple of the resolution. It also gives an error when the start coordinate is not a multiple of the resolution.
Modified multivec.py to fix a bug to handle headers. The header identifier was not working on .gz input files because they are in bytes. Now it works in both gzipped and unzipped input files.
Modified multivec.py to add a cmv.create_multivec_multires version for states files since the states row_infos file has two columns (name of state and color), both columns were showing as the name of the state, now it only shows the first column.
Fixes # 3
Checklist