higlass / clodius

Clodius is a tool for breaking up large data sets into smaller tiles that can subsequently be displayed using an appropriate viewer.
MIT License
38 stars 21 forks source link

Retain lines when end coordinate is not multiple of resolution #110

Closed Lmercadom closed 4 years ago

Lmercadom commented 4 years ago

Description

What was changed in this pull request and Why is it necessary?

Fixes # 3

Checklist

pkerpedjiev commented 4 years ago

Thanks for the PR Luisa! I made some inline suggestions but more importantly than that, would you mind adding some tests?

Also, could you update the CHANGELOG with your changes?

pkerpedjiev commented 4 years ago

Looks reasonable. A minor comment: your test file contains values for chr1 and chr2 but you never use chr2 in the actual test. Does it need to be in the test file or is it just a red herring?

Lmercadom commented 4 years ago

It is just a red herring. I just wanted to signal that chr1 ended.