search

higlass / higlass-docker

Builds a docker container wrapping higlass-server and higlass-client in nginx
MIT License
32 stars 14 forks source link

Added GitHub actions #171

Closed pkerpedjiev closed 3 years ago

pkerpedjiev commented 3 years ago

Thanks for the review!

I am a little confused (see comments). Is bumpversion supposed to do the tagging (with v... and thus trigger dockerpublish?

Yes, that's exactly right. bumpversion's pretty awesome. These two lines:

commit = True
tag = True

Tell it to create a new commit and tag it once it updates the version number wherever we tell it to.

alexander-veit commented 3 years ago

Oh... I did not realize that bumpversion is a python package. I thought it's just a script you wrote. After looking at the docs, everything makes a lot more sense. Thanks for clarifying.