search

higoka / habbo-downloader

⚡A tiny script to download various files directly from Habbo.
https://www.npmjs.com/package/habbo-downloader
MIT License
59 stars 32 forks source link

Added Help, Download Progress, Terminal colors #7

Closed salomaosnff closed 4 years ago

salomaosnff commented 4 years ago

Colors image Help image Download progress image

higoka commented 4 years ago

thanks for your contibution and effort but i would like to adress some things here.

  1. i like the idea of a progress bar but i think its a bit to overkill to create a entire Terminal class for that. we could use a simple function for that not copy paste something from a symfony package. i like things to be as simple and minimal as possible but yet efficient and functional.
  2. i like the help command only thing is that it also depends on the Terminal class. a simple echo would work too.
  3. for the colors im not sure what you added? colors should already be there.

dont take it the wrong way, i like your ideas and contribution but the goal of this project is to be a tiny litte script for downloading files from habbo. we can implement this but we need to change some things to be as simple as possible. maybe with v2 we rewrite the entire script with proper oop and psr standards or entirely with javascript.