search

hiiamrohit / Countries-States-Cities-database

Database & Dropdown Demo
http://www.iamrohit.in/countries-states-and-cities-database-of-world-in-mysql/
919 stars 1.07k forks source link

delete duplicated data #6

Closed balthild closed 6 years ago

balthild commented 8 years ago

Some states and cities data are obsolete, I've deleted it.

javydreamercsw commented 8 years ago

It looks clean besides I haven't checked the reason behind them being obsolete. Could you elaborate on why they are obsolete? Is not like they were wiped out of the face of the earth.

Are they duplicated instead? If so can you provide more detail?

balthild commented 8 years ago

Anhui, Anhui Province, Anhui Sheng Fujian, Fujian Sheng Jiangsu, Jiangsu Sheng Liaoning, Liaoning Sheng Shandong, Shandong Sheng Zhejiang, Zhejiang Sheng The word Sheng means Province in Chinese. They refers to a same place whether with or without a Sheng or a Province.

javydreamercsw commented 8 years ago

So for example keep Anhui, and delete Anhui Province, Anhui Sheng?

javydreamercsw commented 8 years ago

Are those the only ones?

javydreamercsw commented 8 years ago

It would be easier if you provide the modified file for review.

balthild commented 8 years ago

Yes, these province are the only ones in China. I'm a Chinese, you see. The commit i requested (4b07d94cd68a41a6fa77b9990523d21128ba2151) is the modification.

javydreamercsw commented 6 years ago

I'm including your changes on PR #46.