search

hiidef / oauth2app

Django OAuth 2.0 Server App. Please fork and improve!
https://github.com/hiidef/oauth2app
MIT License
271 stars 115 forks source link

Add urls and views #20

Open jjdelc opened 12 years ago

jjdelc commented 12 years ago

Adding oauth2app a views module and pluggable url patterns.

Updated the example project to use those.

bhagany commented 12 years ago

Some sort of strangeness here - github won't let me automatically merge this. Kind of makes me nervous, but I don't immediately understand why, unless it's because there are commits that have already been made in the pul request?

pydanny commented 12 years ago

IMO, Github auto-merges should only be used on documentation changes, not for logic/functionality changes.

pydanny commented 12 years ago

Upon review, this should be merged in. I don't have rights, but it looks very solid to me.

jjdelc commented 12 years ago

Sorry guys, I've been offline during hte week, I'll go ahead and do a request without the duplicate commits.

bhagany commented 12 years ago

Apologies here too, I've had a pretty busy half-week or so.

jonas-grgt commented 11 years ago

This should be merged in, why hasn't this been merged in yet ?

bhagany commented 11 years ago

As you can see in the comments, I was left expecting an updated request without duplicate commits, and so dropped it.

bhagany commented 11 years ago

The patch also removes simplejson as a dependency, and while I can sympathize with that goal, it has a few effects that I'm not sure I can support -