search

hiitiger / goverlay

DirectX hook and game overlay solution for Electron, Qt and CEF, just like discord/steam game overlay,inject any app to overlay in your game
Other
783 stars 108 forks source link

A terminal flashes and then disappears when goverlay attampts injecting dll to a game #114

Closed yun77op closed 10 months ago

yun77op commented 10 months ago

It's unnecessary and annoying to the end user.

After some digging. Maybe the problem lies in https://github.com/hiitiger/goverlay/blob/master/electron-overlay/src/utils/win-utils.h#L105. Should we pass CREATE_NO_WINDOW to the sixth parameter?

before

BOOL ret = CreateProcessW(path.c_str(), (LPWSTR)(cmdLine.c_str()), NULL, NULL, FALSE, 0, NULL, dir.c_str(), &StartupInfo, &ProcInfo);

after

BOOL ret = CreateProcessW(path.c_str(), (LPWSTR)(cmdLine.c_str()), NULL, NULL, FALSE, CREATE_NO_WINDOW, NULL, dir.c_str(), &StartupInfo, &ProcInfo);

Any thoughts? Thanks.

hiitiger commented 10 months ago

@yun77op fixed here https://github.com/hiitiger/goverlay/commit/3316015af72f46e46c5de7d2b96a470d0be62517