Reviving this - Githubissues

hiitiger / goverlay

DirectX hook and game overlay solution for Electron, Qt and CEF, just like discord/steam game overlay,inject any app to overlay in your game

Other

797 stars 110 forks source link

Reviving this #46

Open honzapatCZ opened 3 years ago

honzapatCZ commented 3 years ago

Looks like @hiitiger lost interest, but I still think this is useful, I know a bit about c++, so I can do small adjustments but understanding this source is pretty hard First of all I think we should update it to the newest VS2019 Anyone wanna help?

Pospelove commented 3 years ago

@honzapatCZ I am interested. How do I contact you?

honzapatCZ commented 3 years ago

@Pospelove One of us should fork the repo and we should continue the work there, My fork has dependabot configured for js, I know the changes there were working some time ago, but Iam not able to compile them now.

honzapatCZ commented 3 years ago

@Pospelove happy to announce that I made my fork compile again

Pospelove commented 3 years ago

@honzapatCZ Great. I am very interested in this lib. Thinking about dropping CEF in my project and use gelectron instead. I have been using Node native addons for years so we could be doing fantastic things (and maybe pull request back to the main repo). Consider adding me in Discord: Pospelov#3228 or write your ID in your-favorite-messenger. I think it would be reasonable to communicate, discuss ideas, etc via messengers, not gelectron issues. :)

honzapatCZ commented 3 years ago

@hiitiger Can you elaborate why was the app separated like that? Iam thinking about merging the thread and process injection into node-ovhook (yes the 32 bit injection will be harder) and then merging this alltogether into electron-overlay making it only 2 separate projects game-overlay and electron-overlay

cpainchaud commented 3 years ago

@honzapatCZ I am following your progress with care! First of all thank you for making it compilable and update to set with modern toolset (even if I am looking to use your project to revive an old abandonned game using DirectX9....) I am looking for the following features/howto right now:

Embedding all this in a way to that end users will not have to know/care about starting electron and looking for the window name. My game has a launcher but I suppose I will need to Electron's thread ID to start the injector from outside and/or start NPM/Electron with a PID of my game as an argument
support for full screen (currently it seems to ignore full screen apps, also switching an injected app from window to fullscreen seems to crash the game, for future reference this may help https://www.unknowncheats.me/forum/direct3d/326798-directx-createdevice-hooking-fullscreen-game.html)

honzapatCZ commented 3 years ago

@cpainchaud 1) Take a look yourself I nor @Pospelove have made any docs atm as there are more important changes, but it should be possible 2) Given that electron does proper DirectX hook, there shouldnt be problem in this, it should work in fullscreen and in windowed, but in both cases you need to Focus the window for the injection to start

AnAkkk commented 3 years ago

@honzapatCZ Not sure if you are still working on this, but there is a performance issue with the current hooks and mice that have a high polling rate. More info here https://github.com/hiitiger/gelectron/issues/53

honzapatCZ commented 3 years ago

@honzapatCZ Not sure if you are still working on this, but there is a performance issue with the current hooks and mice that have a high polling rate. More info here #53

Interesting, not actively, but you are free to make suggestions or PRs

gulbrillo commented 3 years ago

@cpainchaud

Given that electron does proper DirectX hook, there shouldnt be problem in this, it should work in fullscreen and in windowed, but in both cases you need to Focus the window for the injection to start

/node-ovhook/src/main.cc

bool include_minimized = false;

set this to true and injection into minimized full-screen windows will work