search

hiivan / pe

0 stars 0 forks source link

Does not detect name duplicate robustly when there are extra white spaces. #2

Open hiivan opened 2 months ago

hiivan commented 2 months ago

Description Detecting only the exact string/value matches is not enough. Extra white space (e.g., the user typed an extra space between the two names) is unlikely to mean they are two different persons (e.g. John Doe and John Doe are probably the same person).

This common bug description was taken from the CS2103T tP: Practical Exam (PE) admin info page.

Steps to reproduce

  1. Open up the app.
  2. Input add n\John Doe e\johndoe@example.com a\574 Ang Mo Kio Ave 10 p\12345678 A\L293D
  3. Then input add n\John Doe e\johndoe@example.com a\574 Ang Mo Kio Ave 10 p\12345678 A\L293D

Expected behaviour

Actual behaviour

Possible solution Improve on the current duplicate detection feature, to catch whitespaces and also make sure the names are turned into the right capitalization when comparing the name.

Conclusion It can be quite common for logistic managers to key in the same name twice, with some differences in white spaces in between the first and last name, especially for names with multiple words in them which can increase the chances of extra whitespaces. It is important to catch these duplicates if not it will cause quite a lot of hindrance when managing these logistics and counting the assets. Hence, the bug is of low/medium severity.

Screenshot image.png

nus-se-bot commented 2 months ago

Team's Response

Thank you for the bug report. As stated in our Planned Enhancements:

image.png

This covers various issues related to duplicate checking, including whitespace detection. Capitalization was only one of the many examples associated with duplicate checking of contacts.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]