search

hijiriworld / intuitive-custom-post-order

WordPress Plugin: Intuitive Custom Post Order
68 stars 33 forks source link

Fixes "Undefined offset: 0" #53

Open diego-betto opened 1 year ago

diego-betto commented 1 year ago

Reference: https://wordpress.org/support/topic/undefined-offset-0-14/

timohubois commented 1 year ago

@diego-betto thanks for the PR. Can you provide more details about where exactly, you got the error? And have you tested the changes also with a multisite setup?

hijiriworld commented 1 year ago

@diego-betto I think your fix is ​​better code, but I also can't confirm the reproducibility of the error. I would like to ask the same question as @timohubois.

diego-betto commented 1 year ago

Error was on a production website with 40k posts and 20k terms. I can recreate a local env to test it but not immediately (busy times, sorry). The "fix" was made to avoid blank pages.

@timohubois no, not tested with a multisite setup

timohubois commented 11 months ago

@diego-betto can you test the changes with a multipage as well?

timohubois commented 10 months ago

@diego-betto did you found the time to test it on a multipage? And can you maybe resolve the conflicts?

diego-betto commented 10 months ago

Hi, I'm sorry but at this time unfortunately I am no longer on WordPress, it is impossible for me to test