search

hikalkan / scs

TCP Server/Client Communication and RMI Framework
MIT License
225 stars 112 forks source link

Implemented [local] named pipe transport support. #2

Open lor3 opened 10 years ago

lor3 commented 10 years ago

Not sure if you are interested in this, in my tests (Windows 8.1/64-bit) TCP connections were around 50% faster which was a bit of a surprise, but this may not be the case for older Windows versions.

Could be made into an external module if some Scs internals were made public.

Review on Reviewable

lor3 commented 9 years ago

src/Scs/Communication/Scs/Communication/Channels/Pipes/NamedPipeConnectionListener.cs, line 72 [r1] (raw file): Why?

Comments from the review on Reviewable.io

menduz commented 8 years ago

👍🏻

hikalkan commented 8 years ago

Hi,

Your effort is valuable. But I also did implemented NamedPipes as communication channel. But saw that it's slower than TCP (especially when using mutexes to control read/write to named pipe). And then I removed it since TCP is more generic and it has no resctriction to be in same computer like named pipes.

So, I think to not include named pipes to SCS. If you really like, you may publish it as a seperated library. So, anyone can add reference to your library and use it in SCS.

Thanks a lot.