Add None value handling for JSONObject builder

hikari-py / hikari

A Discord API wrapper for Python and asyncio built on good intentions.

https://docs.hikari-py.dev/en/stable

MIT License

806 stars 95 forks source link

Add None value handling for JSONObject builder #2021

Open syncblaze opened 1 month ago

syncblaze commented 1 month ago

Summary

If whe build a json object, the value should not be added to the json if its undefined type, but if its None it should just be added as None. These None checks were performed in the rest functions etc which used the JSON Object builder until now, but it makes far more sense to put this None check into the json builder.

Checklist

[x] I have run nox and all the pipelines have passed.
[x] I have made unittests according to the code I have added/modified/deleted.

Related issues

syncblaze commented 1 month ago

Merging this as is could cause some slowdowns because of the double check for None that are lying around, would be nice to incorporate that into this pr too

i can do that no problem