hikariatama / Hikka

The most fresh and updateable developer-oriented Telegram userbot
https://hikka.pw
GNU Affero General Public License v3.0
315 stars 506 forks source link

A "sudo" user can add and remove "owner" users (including themselfs) #93

Closed penggrin12 closed 1 year ago

penggrin12 commented 1 year ago

To Reproduce Steps to reproduce the behavior:

  1. Add someone to the sudo group
  2. Now they can do .owneradd on themselfs, giving them owner access

Expected behavior Some sort of "Permission Denied" error

Userbot installation info:

Additional context An easy fix should be just to add @loader.owner on all of the *add and *rm commands in hikka_security.py (thanks to @visionavtr, for finding this out)

hikariatama commented 1 year ago