hikarin522 / GlassIt-VSC

VS Code Extension to set window to transparent on Windows platform.
https://marketplace.visualstudio.com/items?itemName=s-nlf-fh.glassit
MIT License
203 stars 21 forks source link

Command 'glassit.increase' not found #45

Closed angelzarza closed 1 year ago

angelzarza commented 1 year ago

As of this version the extension stopped working causing the error: (command 'glassit.increase' not found) when trying to use the shortcut ctrl+alt+z.

PotatoesFall commented 1 year ago

I am experiencing this differently.

I have both VSCode and VSCodium installed.

In code, the extension works fine.

If I run both code and vscodium next to each other, the transparency works as well, but I can only modify it when the focussed window is code. Changing the setting in the codium settings.json does not have an effect (and gives me the error message described in the title), but changing it in codes settings.json affects both windows, so long as I opened the code window after the codium window. If I close code, the transparency persists in codium, but if I open a new codium window it doesn't work until I open a new vscode window as well.

if I only run codium, there is no transparency.

➤ code -v
1.75.1
441438abd1ac652551dbe4d408dfcec8a499b8bf
x64

➤ codium -v
1.75.1
c6a9727b801542499d2b59cb7db4224e060fc578
x64

EDIT more details:

from extension host logs:

2023-02-15 16:08:57.405 [error] Activating extension s-nlf-fh.glassit failed due to an error:
2023-02-15 16:08:57.405 [error] Error: Command failed: pgrep 'code'

the relevant code is:

            // Retrieve the process name for the current VS Code instance (Solution for using forks of VS Code)
            const process_name = process.title.substring(process.title.lastIndexOf('/') + 1);

            // Retrieving the process ids of VS code
            const processIds = cp.execSync(`pgrep ${process_name}`).toString().split('\n');

This is weird, if I check my processes, there are no code processes, so I don't understand why process_name does not end up being codium

aygharib commented 1 year ago

This extension was working for me in VSCode on Ubuntu 22.10, but seems to have stopped working as of a few weeks ago. I believe it happened after I upgraded as @angelzarza said.

PotatoesFall commented 1 year ago

@aygharib @angelzarza perhaps you should check the extension logs to see what is going wrong. Ctrl+Shift+P (command palette) > Developer: Show Logs > Extension Host

I've submitted https://github.com/hikarin522/GlassIt-VSC/pull/46 for my issue but it's likely you guys have a different problem.

angelzarza commented 1 year ago

@PotatoesFall

[info] ExtensionService#_doActivateExtension s-nlf-fh.glassit, startup: true, activationEvent: '*'
[error] Activating extension s-nlf-fh.glassit failed due to an error:
[error] Error: Command failed: pgrep 119
    at checkExecSyncError (node:child_process:848:11)
    at Object.execSync (node:child_process:922:15)
    at Object.execSync (node:electron/js2c/asar_bundle:5:12704)
    at activate (/home/angel/.vscode/extensions/s-nlf-fh.glassit-0.2.5/extension.js:55:35)
    at Ui.db (/snap/code/119/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:108:14818)
    at Ui.cb (/snap/code/119/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:108:14519)
    at /snap/code/119/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:108:12519
    at async f.n (/snap/code/119/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:94:6818)
    at async f.m (/snap/code/119/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:94:6781)
    at async f.l (/snap/code/119/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:94:6238)
aygharib commented 1 year ago

Problem looks to be resolved after #46 was merged. Thanks for the help @PotatoesFall

aygharib commented 1 year ago

@angelzarza Can you close this issue if the problem has been fixed on your end as well?