search

hikarin522 / GlassIt-VSC

VS Code Extension to set window to transparent on Windows platform.
https://marketplace.visualstudio.com/items?itemName=s-nlf-fh.glassit
MIT License
203 stars 21 forks source link

[Linux] fix process title not being correct causing breakage on forks #46

Closed PotatoesFall closed 1 year ago

PotatoesFall commented 1 year ago

The issue is described in this comment: https://github.com/hikarin522/GlassIt-VSC/issues/45#issuecomment-1428000020

The process title is an editable value which can apparently be overwritten by other extensions, if my understanding is correct.

My proposal is to instead use process.execPath . I have tested this on my system with both code and codium and it appears to work for both. I don't know much about node so I myself can't promise this is a perfect fix.

hikarin522 commented 1 year ago

LGTM

PotatoesFall commented 1 year ago

@hikarin522 awesome, thank you! Will the official extension update automatically, or does a release need to be made?

hikarin522 commented 1 year ago

I merged this pull request and released it as v0.2.6.

https://marketplace.visualstudio.com/items?itemName=s-nlf-fh.glassit