Remove unused templates: Indicators

ninetteadhikari commented 4 years ago

Is your feature request related to a problem? Please describe. Currently there are a lot of files in the template which are no longer being used. Following is the list of all the files in the indicators folder marking them as: :white_check_mark: OK :warning: Needs change :x: Review and remove

Indicator Consider renaming all templates named as collecteddata --> indicator_results? For all templates that refer to the Indicator consider renaming as indicator_definition since it is defining what we are going to add results to. DEP = Deprecated / Kindly remove

:warning: templates/indicators/form-sections
- This seems to be the indicator details form. Can we rename the folder from form-sections to indicator_definition so that it is more descriptive?
:warning: templates/indicators/forms
- Can we rename this folder to be more precise of what it includes?
- Suggestion: target_results_modal
:x: templates/indicators/add_collecteddata_modal.html
- this can be deleted
- this has been replaced by the results_modal.html
:white_check_mark: templates/indicators/add_indicator_modal.html
:x: templates/indicators/collected_data_report_table.html
- This is DEP and removed from Reports and will be replaced with the new IPTT
:x: templates/indicators/collected_data_table.html
- I assume this can be delete as it is a duplicate of the template collected_data_table2
:warning: templates/indicators/collected_data_table2.html
- Change name to collected_data_table
:x: templates/indicators/collecteddata_confirm_delete.html
- I assume this can be delete as its covered in collected_data_table2
:x: templates/indicators/collecteddata_form_common_js.html
- This seems to include target period validation. Check with Isaac on if it still used in any of his work on indicators. Otherwise to be deleted
:x: templates/indicators/collecteddata_form_modal.html
- I assume this can be deleted as it is replaced by results_modal.html
:x: templates/indicators/collecteddata_form.html
- Is this form no longer being used since Isaac reimplemented using Vue?
:x: templates/indicators/collecteddata_import.html
- This was used to help users import a data table and link it to indicator results as evidence. This can be removed but we will want to learn from this aggregation logic so we can link the Form Library with the Indicator results in the future.
:x: templates/indicators/collecteddata_list.html
- Is this being used anywhere in the app currently? I cant tell what it is doing.
:warning: templates/indicators/crispy.html
- Do we need this? This was part of the initial commit. If so can we reorganize and possibly rename to be more descriptive.
- Suggestion: indicator_crispy_form
:x: templates/indicators/dashboard.html
- Is this being used currently? If so, can we reorganize and rename?
:x:templates/indicators/data_report.html
- Where is this being used
- Consider renaming to be more descriptive.
:x: templates/indicators/disaggregation_print.html
- We would like to reuse the print feature here. Check with Isaac when he works on the Disaggregation Report and if he can reuse any of the code. If not, remove.
:x: templates/indicators/disaggregation_report.html
- Is this a starting place for Isaac’s disaggregation report? Once it is review, go ahead and remove.
:x: templates/indicators/faq.html
- DEP This can be removed. We are currently not using FAQs in the app.
:x: templates/indicators/grid_report.html
- DEP This is currently not in use and can be removed.
:x: templates/indicators/home.html
- DEP This is currently not in use and can be removed.
:white_check_mark: templates/indicators/indicator_confirm_delete.html
:white_check_mark: templates/indicators/indicator_create.html
:warning: templates/indicators/indicator_form_common_js.html
- There is a lot of commented out code in this template. Can we remove and explore if this template is still used? If not, go ahead and remove.
:warning: templates/indicators/indicator_form_modal.html
- Reorganize into a folder and consider renaming with indicator_defintion
:warning: templates/indicators/indicator_form_tab_ui.html
- Reorganize into a folder and consider renaming with indicator_defintion
:warning: templates/indicators/indicator_form.html
- Reorganize into a folder and consider renaming with indicator_defintion
:x: templates/indicators/indicator_graphs.html
- DEP Not in use, remove.
:white_check_mark: templates/indicators/indicator_list.html
:x: templates/indicators/level_update_form.html
- Using Vue.js for Levels
:x: templates/indicators/program_indicators_table.html
- Check if this template is currently used, if not, kindly remove.
:x: templates/indicators/report.html
- See if logic can be reused for export CSV feature. Once review, this can be removed. See GH Issue: https://github.com/hikaya-io/activity/issues/480
:x: templates/indicators/site_profile_map.html
- Should this template belong in the Components section, not under Indicator?
:x: templates/indicators/strategicobjective_update_form.html
- Using Vue.js for Objectives
:x: templates/indicators/tool.html
- Review if this being used otherwise delete.
:x: templates/indicators/tva_print.html
- Review if this being used otherwise delete. Can be used as reference for future print feature
:x: templates/indicators/tva_report.html
- Review if this being used otherwise delete. Can be used as reference for future TvA report feature

TAnas0 commented 4 years ago

Note that the branch 485-clean-templates has a single commit where the following templates are deleted:

templates/indicators/add_collecteddata_modal.html
templates/indicators/collected_data_report_table.html
templates/indicators/collected_data_table.html
templates/indicators/collecteddata_confirm_delete.html
templates/indicators/collecteddata_form.html
templates/indicators/collecteddata_form_modal.html
templates/indicators/faq.html
templates/indicators/grid_report.html
templates/indicators/home.html
templates/indicators/indicator_graphs.html
templates/indicators/tool.html

I'll make a PR for it since it handles the most obvious changes of the list. See PR #520

TAnas0 commented 4 years ago

Reopening since the PR only addressed the original issue partially

hikaya-io / activity

Remove unused templates: Indicators #513