search

hikaya-io / activity

Making it easier for nonprofits to manage their project activities and indicators. Interested in contributing? Check out our open issues: https://tinyurl.com/activity-issues
https://hikaya.io/products/activity/
Apache License 2.0
80 stars 5 forks source link

Service crud #715

Closed myugetsu closed 3 years ago

myugetsu commented 4 years ago

What is the Purpose?

creating crud backend and front-end functionality for services

andrewtpham commented 4 years ago

@TAnas0 @myugetsu I see the Travis runs are failing. If we're planning to remove Travis in the near future, is it okay that they are failing? Or we need Travis to pass so we dont have the flake8 conflicts?

codecov[bot] commented 4 years ago

Codecov Report

Merging #715 (7436a38) into develop (a2a0a51) will increase coverage by 0.79%. The diff coverage is 88.65%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #715      +/-   ##
===========================================
+ Coverage    56.41%   57.20%   +0.79%     
===========================================
  Files          142      143       +1     
  Lines         8948     9137     +189     
===========================================
+ Hits          5048     5227     +179     
- Misses        3900     3910      +10
Impacted Files Coverage Δ
formlibrary/urls.py 100.00% <ø> (ø)
formlibrary/views.py 68.69% <77.55%> (+5.73%) :arrow_up:
formlibrary/forms.py 86.20% <100.00%> (+22.57%) :arrow_up:
formlibrary/models/service.py 89.65% <100.00%> (+1.19%) :arrow_up:
formlibrary/serializers.py 98.07% <100.00%> (+1.20%) :arrow_up:
formlibrary/tests/test_service.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a2a0a51...b6d2e2d. Read the comment docs.

ninetteadhikari commented 3 years ago

@myugetsu this is really great work! 💪 😄 I was testing out the Service form and had some comments:

andrewtpham commented 3 years ago

@myugetsu To rebase PR to remove unrelated commits

ninetteadhikari commented 3 years ago

@myugetsu

  1. Creating new Service is throwing error

    image

  2. Clicking on the name of the Service should direct to the Edit page. Currently clicking on the name of the service is not doing anything

  3. Clicking on the "Project" and the "Program" filter is throwing error. If this is too complex to fix, suggest removing these for now

    image
myugetsu commented 3 years ago

@myugetsu

  1. Creating new Service is throwing error
image
  1. Clicking on the name of the Service should direct to the Edit page. Currently clicking on the name of the service is not doing anything
  2. Clicking on the "Project" and the "Program" filter is throwing error. If this is too complex to fix, suggest removing these for now
image

let me check its not hard to fix though its odd that its happening on your end let me check again

myugetsu commented 3 years ago

@ninetteadhikari have you been able to pull the current changes and try again on this branch

ninetteadhikari commented 3 years ago

@ninetteadhikari have you been able to pull the current changes and try again on this branch

hmm this is strange I pulled the new changes locally and am still getting the above issues... @andrewtpham or @sannleen do you mind checking as well and see if you have any issues?

myugetsu commented 3 years ago

@ninetteadhikari let me see if i am missing anything on my end

myugetsu commented 3 years ago

@ninetteadhikari i have just fixed the filter issue should work now when you pull the code, as for the first issue with creating a new service am currently not having the same issue.

andrewtpham commented 3 years ago

@ninetteadhikari i have just fixed the filter issue should work now when you pull the code, as for the first issue with creating a new service am currently not having the same issue.

@myugetsu I just pull the latest from your branch but getting a 500 server error when I try to create a Service (training or distribution): image

I am also facing a 404 error (page not found) when I click on the filter to try and view any services under the program I selected: ![Uploading image.png…]()

andrewtpham commented 3 years ago

@ninetteadhikari i have just fixed the filter issue should work now when you pull the code, as for the first issue with creating a new service am currently not having the same issue.

@myugetsu I just pull the latest from your branch but getting a 500 server error when I try to create a Service (training or distribution): image

I am also facing a 404 error (page not found) when I click on the filter to try and view any services under the program I selected: image