Closed myugetsu closed 3 years ago
Merging #721 (cdd4061) into develop (deceead) will increase coverage by
0.07%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## develop #721 +/- ##
===========================================
+ Coverage 57.21% 57.29% +0.07%
===========================================
Files 143 143
Lines 9128 9144 +16
===========================================
+ Hits 5223 5239 +16
Misses 3905 3905
Impacted Files | Coverage Δ | |
---|---|---|
formlibrary/tests/test_service.py | 100.00% <ø> (ø) |
|
formlibrary/serializers.py | 98.48% <100.00%> (+0.56%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update deceead...cdd4061. Read the comment docs.
@myugetsu does date of birth have to be required? or can it be made optional?
@myugetsu does date of birth have to be required? or can it be made optional?
it's not a must just depends on which direction we pick to go with
@myugetsu does date of birth have to be required? or can it be made optional?
it's not a must just depends on which direction we pick to go with
so i have set the date of birth as required since the backend is currently performing the filter for the field
@myugetsu To rebase the PR to remove other commits not related to this PR
This looks okay from my end. @nasirhjafri if you can give this a quick review then we can close it :)
This looks okay from my end. @nasirhjafri if you can give this a quick review then we can close it :)
@myugestu Please remove unrelated commits.
This looks okay from my end. @nasirhjafri if you can give this a quick review then we can close it :)
@myugestu Please remove unrelated commits.
let me see i did a rebase of the commit and removed them let me check again
@nasirhjafri seems i did not rebase the commits properly let me see if i can sort out the commits
updated the required fields