hikaya-io / activity

Making it easier for nonprofits to manage their project activities and indicators. Interested in contributing? Check out our open issues: https://tinyurl.com/activity-issues
https://hikaya.io/products/activity/
Apache License 2.0
80 stars 5 forks source link

Individual list 690 #721

Closed myugetsu closed 3 years ago

myugetsu commented 3 years ago

updated the required fields

codecov[bot] commented 3 years ago

Codecov Report

Merging #721 (cdd4061) into develop (deceead) will increase coverage by 0.07%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #721      +/-   ##
===========================================
+ Coverage    57.21%   57.29%   +0.07%     
===========================================
  Files          143      143              
  Lines         9128     9144      +16     
===========================================
+ Hits          5223     5239      +16     
  Misses        3905     3905              
Impacted Files Coverage Δ
formlibrary/tests/test_service.py 100.00% <ø> (ø)
formlibrary/serializers.py 98.48% <100.00%> (+0.56%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update deceead...cdd4061. Read the comment docs.

ninetteadhikari commented 3 years ago

@myugetsu does date of birth have to be required? or can it be made optional?

myugetsu commented 3 years ago

@myugetsu does date of birth have to be required? or can it be made optional?

it's not a must just depends on which direction we pick to go with

myugetsu commented 3 years ago

@myugetsu does date of birth have to be required? or can it be made optional?

it's not a must just depends on which direction we pick to go with

so i have set the date of birth as required since the backend is currently performing the filter for the field

andrewtpham commented 3 years ago

@myugetsu To rebase the PR to remove other commits not related to this PR

ninetteadhikari commented 3 years ago

This looks okay from my end. @nasirhjafri if you can give this a quick review then we can close it :)

nasirhjafri commented 3 years ago

This looks okay from my end. @nasirhjafri if you can give this a quick review then we can close it :)

@myugestu Please remove unrelated commits.

myugetsu commented 3 years ago

This looks okay from my end. @nasirhjafri if you can give this a quick review then we can close it :)

@myugestu Please remove unrelated commits.

let me see i did a rebase of the commit and removed them let me check again

myugetsu commented 3 years ago

@nasirhjafri seems i did not rebase the commits properly let me see if i can sort out the commits