search

hikaya-io / activity

Making it easier for nonprofits to manage their project activities and indicators. Interested in contributing? Check out our open issues: https://tinyurl.com/activity-issues
https://hikaya.io/products/activity/
Apache License 2.0
80 stars 5 forks source link

Fix installation of `cryptography` PIP package in Docker build #752

Closed TAnas0 closed 3 years ago

TAnas0 commented 3 years ago

What is the Purpose?

Fix the Docker build image step occuring on Github Actions: https://github.com/hikaya-io/activity/actions/runs/1158606024 Issue is during the PIP packages install, more specifically the cryptography package, which is not a direct dependency of ours (through pendulum package)

What was the approach?

Since we are using cryptography<3.5, we can just disable the Rust build during the install using an environment variable: https://github.com/pyca/cryptography/issues/5771#issuecomment-775016788

The whole Github issue also addresses how to install Rust if we want to upgrade cryptography

Are there any concerns to addressed further before or after merging this PR?

None

Mentions?

@michaelbukachi

Issue(s) affected?

None

codecov[bot] commented 3 years ago

Codecov Report

Merging #752 (b583e31) into develop (73921f3) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #752   +/-   ##
========================================
  Coverage    57.61%   57.61%           
========================================
  Files          143      143           
  Lines         9223     9223           
========================================
  Hits          5314     5314           
  Misses        3909     3909