hikaya-io / activity

Making it easier for nonprofits to manage their project activities and indicators. Interested in contributing? Check out our open issues: https://tinyurl.com/activity-issues

https://hikaya.io/products/activity/

Apache License 2.0

80 stars 5 forks source link

refactor(CI): Move Docker commands to the right Dockerfile #754

Closed TAnas0 closed 3 years ago

TAnas0 commented 3 years ago

What is the Purpose?

PR https://github.com/hikaya-io/activity/pull/752 was not successful. This is a revert of that PR and reimplementation of the bug fix

What was the approach?

Edited the right Dockerfile used in deployment Bash script

Are there any concerns to addressed further before or after merging this PR?

Mentions?

@michaelbukachi @Kimaiyo077

Issue(s) affected?

https://github.com/hikaya-io/activity/actions/runs/1158933148

codecov[bot] commented 3 years ago

Codecov Report

Merging #754 (c1fabbb) into develop (5f51c4d) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #754   +/-   ##
========================================
  Coverage    57.61%   57.61%           
========================================
  Files          143      143           
  Lines         9223     9223           
========================================
  Hits          5314     5314           
  Misses        3909     3909