hikaya-io / activity

Making it easier for nonprofits to manage their project activities and indicators. Interested in contributing? Check out our open issues: https://tinyurl.com/activity-issues

https://hikaya.io/products/activity/

Apache License 2.0

80 stars 5 forks source link

Remove secrets from Docker image #762

Closed TAnas0 closed 3 years ago

TAnas0 commented 3 years ago

What is the Purpose?

What was the approach?

Deleted file that gathers environment variables before building the new Docker image

Are there any concerns to addressed further before or after merging this PR?

Check the pushed Docker image for secrets

Mentions?

@michaelbukachi

Issue(s) affected?

Fix #759

codecov[bot] commented 3 years ago

Codecov Report

Merging #762 (112f93f) into develop (7b846dc) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #762   +/-   ##
========================================
  Coverage    57.61%   57.61%           
========================================
  Files          143      143           
  Lines         9223     9223           
========================================
  Hits          5314     5314           
  Misses        3909     3909