search

hikaya-io / activity

Making it easier for nonprofits to manage their project activities and indicators. Interested in contributing? Check out our open issues: https://tinyurl.com/activity-issues
https://hikaya.io/products/activity/
Apache License 2.0
80 stars 5 forks source link

feat(CI): update Docker credentials and Docker image names #781

Closed TAnas0 closed 1 year ago

TAnas0 commented 2 years ago

What is the Purpose?

Use the new Digitalocean container registry in CI scripts and Github Actions

What was the approach?

Added a secret with the DO access token

Are there any concerns to addressed further before or after merging this PR?

Mentions?

@andrew @ninetteadhikari

Issue(s) affected?

None

codecov[bot] commented 2 years ago

Codecov Report

Merging #781 (b1a9f30) into develop (abdcd53) will not change coverage. The diff coverage is n/a.

:exclamation: Current head b1a9f30 differs from pull request most recent head eff8ac5. Consider uploading reports for the commit eff8ac5 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/hikaya-io/activity/pull/781/graphs/tree.svg?width=650&height=150&src=pr&token=SGT6HP7P95&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hikaya-io)](https://codecov.io/gh/hikaya-io/activity/pull/781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hikaya-io) ```diff @@ Coverage Diff @@ ## develop #781 +/- ## ======================================== Coverage 57.55% 57.55% ======================================== Files 140 140 Lines 9210 9210 ======================================== Hits 5301 5301 Misses 3909 3909 ```
andrewtpham commented 1 year ago

Hey @TAnas0 wanted to ask you about this PR. We are doing a production release to Activity this week and wanted to include any changes in it.

We saw that this updates where to store images in DO container registry instead of DockerHub but we already saw that there exists some Activity images in DO container registry. So my question is this PR ready to merge and is it needed?