search

hikaya-io / hakawati

A collection of UI components
GNU General Public License v3.0
2 stars 1 forks source link

Refactored Dialog Component (UI-59) #103

Closed Tanvir-rahman closed 4 years ago

Tanvir-rahman commented 4 years ago

What is the Purpose?

Basic Dialog

  • Refactor Dialog component to make it reusable. To that end the following needs to be moved from the component to the story to allow for the Dialog to be customized:
    • Modal trigger button
    • Modal width
    • Click handler for the Confirm button
    • Label of the Confirm button
  • Change handleClose to close the Dialog instead of opening another nested Dialog

Form Dialog

  • Same changes as the Basic dialog
  • Move form-item and input fields out of the component so that it is not hardcoded. This will allow the component to be used as a shell where any form item and input fields can be entered.

Same changes as the Basic dialog Move form-item and input fields out of the component so that it is not hardcoded. This will allow the component to be used as a shell where any form item and input fields can be entered.## What was the approach? Briefly describe the approach used to address the issue

Are there any concerns to addressed further before or after merging this PR?

Nope

Mentions?

@ninetteadhikari @andrewtpham

Issue(s) affected?

59

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hikaya/vue-ui-components/clcxsdhsm ✅ Preview: https://vue-ui-components-git-ui-59.hikaya.now.sh