Closed mutebironald closed 4 years ago
vercel[bot]
commented
4 years ago This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/hikaya/vue-ui-components/e24frsfyz ✅ Preview: https://vue-ui-components-git-add-opacity.hikaya.now.sh
andrewtpham
commented
4 years ago Hi @mutebironald I reviewed the preview and dont see the dim effect on the HDrawer or any of the others? Do you how I can see this?
This is what I currently see:
andrewtpham
commented
4 years ago This PR only partially solves the diming issue. The rest will be handled in dots-fe as stated by @mutebironald
ninetteadhikari
commented
4 years ago This PR only partially solves the diming issue. The rest will be handled in dots-fe as stated by @mutebironald
@andrewtpham @mutebironald can we merge and close this issue then? if you are working on the FE on this?
mutebironald
commented
4 years ago This PR only partially solves the diming issue. The rest will be handled in dots-fe as stated by @mutebironald
@andrewtpham @mutebironald can we merge and close this issue then? if you are working on the FE on this?
@ninetteadhikari, I have included the necessary changes needed here for the front end PR https://github.com/hikaya-io/dots-frontend/pull/145.
What is the Purpose?
Briefly describe what the PR addresses Addresses #126 By reducing the sizing of the description text area
What was the approach?
Briefly describe the approach used to address the issue
Are there any concerns to addressed further before or after merging this PR?
State some additional info if any. For instance running
installor setting some environment variable(s) This PR will have a corresponding PR on dots-frontend.Mentions?
Mention persons you'd like to review this PR
Issue(s) affected?
List of issues addressed by this PR.
126