hikaya-io / hakawati

A collection of UI components
GNU General Public License v3.0
2 stars 1 forks source link

Top-nav component: Ability to right-click and see browser options: 1) open in a new tab; 2) copy url address #169

Closed andrewtpham closed 1 year ago

andrewtpham commented 4 years ago

Current behavior When I right-click on an item in the main navigation menu (Data, Maps, Profile), I am not able to open the page on a new tab.

To Reproduce Steps to reproduce the behavior:

  1. Go to main app page and view the main nav menu
  2. Right-click on an item (Data, Maps, Profile icon)
  3. See options: Lookup, copy, etc
  4. See error

image

Expected behavior For example, if I click on a tab in Github, I see these options to open in a new tab: image

I would like to see these options to option in a new tab when I click on a new page (new page = has a different URL)

Maybe the solution is to make each main nav link a link? Reference: https://javascript.info/default-browser-action

ninetteadhikari commented 4 years ago

this involves reviewing the hakawati component

ninetteadhikari commented 4 years ago

Note: to open the navbar elements in a new tab the component needs to be redone completely without using Element UI.

andrewtpham commented 2 years ago

Hey @michaelbukachi do you think we could add this option to the side bar component? This issue can still be used to update the top nav bar component

michaelbukachi commented 2 years ago

@andrewtpham I think so. As long as a valid link is used then it should be possible to right click.

ninetteadhikari commented 1 year ago

after the hakawati PR is merged, some FE changes need to be made for the right click to work