search

hikaya-io / hakawati

A collection of UI components
GNU General Public License v3.0
2 stars 1 forks source link

Hide Tab sidebar on mobile screens #231

Closed Kimaiyo077 closed 3 years ago

Kimaiyo077 commented 3 years ago

What is the Purpose?

Hide Tab sidebar on mobile screens

What was the approach?

Added two classes to elements that needed to be altered on mobile and tablet screens

Are there any concerns to addressed further before or after merging this PR?

State some additional info if any. For instance running install or setting some environment variable(s)

Mentions?

@michaelbukachi

Issue(s) affected?

Close #228

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hikaya/vue-ui-components/Dv1eb4VXFRcHKtKGbw7DWC8PEyPd
✅ Preview: https://vue-ui-components-git-add-slots-to-htab-hikaya.vercel.app

michaelbukachi commented 3 years ago

@Kimaiyo077 The tabs are not hidden. screenshot_20211025185603

andrewtpham commented 3 years ago

@Kimaiyo077 to take another look. The current implementation only the panel disappears when you navigate to another screen and navigate back

Kimaiyo077 commented 3 years ago

@michaelbukachi , I found the issue causing it not to work as expected, I was able to fix it but I found more issues that made it really complex so I decided to just use media queries, can you take a look at it now

michaelbukachi commented 3 years ago

@Kimaiyo077 Still works. Nice work@ :man_dancing:

Kimaiyo077 commented 3 years ago

@Kimaiyo077 Increase the package version so that we can merge this.

Done @michaelbukachi

michaelbukachi commented 3 years ago

@Kimaiyo077 lint checks failed during deployment.