Enhance h-table - Githubissues

hikaya-io / hakawati

A collection of UI components

GNU General Public License v3.0

2 stars 1 forks source link

Enhance h-table #236

Closed michaelbukachi closed 2 years ago

michaelbukachi commented 2 years ago

What is the Purpose?

This PR:

[x] Adds logic for hiding/showing columns in h-table
[x] Adds the ability to use a switch when hiding/showing columns
[x] Adds logic for reordering columns

What was the approach?

Briefly describe the approach used to address the issue

Are there any concerns to addressed further before or after merging this PR?

State some additional info if any. For instance running install or setting some environment variable(s)

Mentions?

@ninetteadhikari @andrewtpham

Issue(s) affected?

Related to #235 Closes #233

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hikaya/vue-ui-components/CsWqXPDKkKzopQnMqyzpnxmWfh7X
✅ Preview: https://vue-ui-components-git-h-table-enhancements-hikaya.vercel.app

ninetteadhikari commented 2 years ago

wow looks really good so far Michael!! 😍

ninetteadhikari commented 2 years ago

Add persistence for table order, column visibility
this is saved per session

This is to be done in a separate PR

andrewtpham commented 2 years ago

@michaelbukachi do you think this added styling to the component could be done in this PR or should we open up in a new Issue? https://github.com/hikaya-io/hakawati/issues/233#issuecomment-981804759

michaelbukachi commented 2 years ago

@andrewtpham I think we can do this in this PR so that we wrap up the drag and drop feature.